Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jpegexiforient: init at 2002-02-17 #73361

Merged
merged 2 commits into from Nov 14, 2019
Merged

jpegexiforient: init at 2002-02-17 #73361

merged 2 commits into from Nov 14, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

This allows feh --edit to work properly, whereas previously it would give

feh WARNING: lossless rotate: Failed to exec jpegexiforient: No such file or directory
feh WARNING: lossless rotate: Failed to update EXIF orientation tag: jpegexiforient returned 1
Things done
  • Built and tested on linux

@ofborg ofborg bot requested review from WilliButz, globin and viric November 13, 2019 19:57
jonringer
jonringer reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would break this out into two commits:

jpegexiforient: init at unstable-2002-02-17
feh: add jpegexiforient to wrapped path

I could see an instance where someone may want to revert the wrapping, and currently they would also have to remove the jpegexiforient package as well

@infinisil
Copy link
Member Author

Yeah, done that

jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executables seem to work
didn't do a proper test

https://github.com/NixOS/nixpkgs/pull/73361
7 package were build:
betterlockscreen deco feh jpegexiforient pywal python38Packages.pywal wpgtk

@infinisil
Copy link
Member Author

feh's build failure on darwin isn't related: https://hydra.nixos.org/job/nixpkgs/trunk/feh.x86_64-darwin

@infinisil infinisil merged commit 5057d2f into NixOS:master Nov 14, 2019
@infinisil infinisil deleted the jpegexiforient branch November 14, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@WilliButz WilliButz Awaiting requested review from WilliButz

@globin globin Awaiting requested review from globin

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @jonringer