nvidia_x11: i686bundled only on i686 systems #73398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this was the original intention and I somehow lost it and never had problems until now. |
baracoder
reviewed
Nov 14, 2019
| @@ -147,7 +147,7 @@ in { | |||
| etc."qemu/bridge.conf".text = lib.concatMapStringsSep "\n" (e: | |||
| "allow ${e}") cfg.allowedBridges; | |||
| systemPackages = with pkgs; [ libvirt libressl.nc iptables cfg.qemuPackage ]; | |||
| etc.ethertypes.source = "${iptables}/etc/ethertypes"; | |||
| etc.ethertypes.source = "${pkgs.iptables}/etc/ethertypes"; | |||
There was a problem hiding this comment.
Seams like an unrelated change, which slipped in
| @@ -30,7 +30,7 @@ assert ! versionOlder version "391" -> stdenv.hostPlatform.system == "x86_64-lin | |||
| let | |||
| nameSuffix = optionalString (!libsOnly) "-${kernel.version}"; | |||
| pkgSuffix = optionalString (versionOlder version "304") "-pkg0"; | |||
| i686bundled = versionAtLeast version "391"; | |||
| i686bundled = stdenv.hostPlatform.system == "i686-linux" && versionAtLeast version "391"; | |||
There was a problem hiding this comment.
If i remember correctly, 391 is the first driver, where nvidia has dropped support for 32bit driver, and the 32bit libraries for steam games and i686 programs run on x64 are bundled in the x64 package.
|
Don't know what happened, but the build seems to work fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @