Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prusa-slicer: use wxGTK31 instead of wxGTK30 #73441

Merged
merged 1 commit into from Dec 3, 2019
Merged

prusa-slicer: use wxGTK31 instead of wxGTK30 #73441

merged 1 commit into from Dec 3, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 15, 2019 •
edited

Motivation for this change

With wxGTK31 3.1.0 there was a bug causing crashes. With the recently merged version 3.1.2 this bug has been fixed.

See #55475 for details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Moredread
prusa-slicer: use wxGTK31 instead of wxGTK30
9702690 
With wxGTK31 3.1.0 there was a bug causing crashes. With the recently
merged version 3.1.2 this bug has been fixed.

See NixOS#55475 for details.
@Moredread
Copy link
Contributor Author

@ArdaXi does that work for you?

@mweinelt
Copy link
Member

Did a test run with nix-review and clicked all over the place - no crashes. LGTM.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/74

Lassulus
Lassulus approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit ba917b2 into NixOS:master Dec 3, 2019
@Moredread Moredread deleted the prusa-gtk branch October 2, 2022 19:56
@Moredread Moredread restored the prusa-gtk branch October 2, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Moredread @mweinelt @nixos-discourse @Lassulus