Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

john: copy rules #73408

Merged
merged 1 commit into from Nov 16, 2019
Merged

john: copy rules #73408

merged 1 commit into from Nov 16, 2019

Conversation

livnev
Copy link
Contributor

@livnev livnev commented Nov 14, 2019

Motivation for this change

Currently, john fails to run with default settings. Simply running $ john path/to/password.hash results in:

fopen: /nix/store/lb1a1ch4hp1pr65rwmqzcx1xzhvy68sa-john-1.9.0-jumbo-1/share/john/rules/best64.rule: No such file or directory

This is because the .rule files weren't copied after the build.

Things done

This PR copies the rules from run/rules so that they are available to john at runtime.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @offlinehacker

@livnev
john: copy rules
4712e67 
copy rules so that they are available to john at runtime
without this, john fails when run with default settings
@ofborg ofborg bot requested a review from offlinehacker November 14, 2019 16:33
jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[2 built, 13 copied (44.8 MiB), 34.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73408
1 package were build:
john

didn't really test as theres ~130 commands in bin

@bjornfor bjornfor merged commit efd3b45 into NixOS:master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@livnev @jonringer @bjornfor