New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk11: split gnome3 and gnome2 deps #73407
Conversation
any opinion? |
How do we test this? |
what do you mean? as in nixos testing framework? No test are needed because default behavior is the same. We can start to disable gnome2 in app by app basis after this. Have sense? |
I meant do you have an app I can test this with? |
Wow, it's true that nobody is using openjdk11 in nixpkgs. I make a grep search and the only candidate is |
I've test ghidra-bin without gnome2 but GUI doesnt work. I'm wondering: with only 2 leaf packages depending on openjdk11 maybe I could try to remove totally gnome2 deps while trying to make ghidra work? |
Do you know if the JavaFX/Swing/whatever is toolkit independent? Is the API abstract enough that apps do not have to care about which version of GTK are we using? If so removing gnome2 deps altogether would be a good idea. |
Sorry but i don't know. i'm not very familiar with Java stuff. Anyways I feel confident to research and test it. |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
Both gtk2/gtk3 is only a runtime dependency, not even a build dependency: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/java-openjdk#n179 |
If https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/net/doc-files/net-properties.html |
The main motivation for this change was to workaround a crash in Bisq software. Nowadays Bisq is working nice with vanilla So I close this PR because have big implications and require in-depth java knowledge. |
Motivation for this change
Change this as a proof of concept to get rid of gnome2 deps in mid-term as requested in #39976. I'm not very familiar with Java but I'm getting problems running applications with these deps: (#72986 and #73246).
If this is the way to go I can change other openjdk versions.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @edwtjo