Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk11: split gnome3 and gnome2 deps #73407

Closed
wants to merge 1 commit into from
Closed

openjdk11: split gnome3 and gnome2 deps #73407

wants to merge 1 commit into from

Conversation

oneingan
Copy link
Contributor

Motivation for this change

Change this as a proof of concept to get rid of gnome2 deps in mid-term as requested in #39976. I'm not very familiar with Java but I'm getting problems running applications with these deps: (#72986 and #73246).

If this is the way to go I can change other openjdk versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo

@oneingan
Copy link
Contributor Author

@oneingan
Copy link
Contributor Author

oneingan commented Dec 3, 2019

any opinion?

@jtojnar
Copy link
Contributor

jtojnar commented Dec 6, 2019

How do we test this?

@oneingan
Copy link
Contributor Author

oneingan commented Dec 6, 2019

what do you mean? as in nixos testing framework? No test are needed because default behavior is the same. We can start to disable gnome2 in app by app basis after this. Have sense?

@jtojnar
Copy link
Contributor

jtojnar commented Dec 6, 2019

I meant do you have an app I can test this with?

@oneingan
Copy link
Contributor Author

oneingan commented Dec 6, 2019

Wow, it's true that nobody is using openjdk11 in nixpkgs. I make a grep search and the only candidate is ghidra-bin, I'm testing it now. Also I'm building Bisq but is not yet finalized for commit.

@oneingan
Copy link
Contributor Author

oneingan commented Dec 6, 2019

I've test ghidra-bin without gnome2 but GUI doesnt work. I'm wondering: with only 2 leaf packages depending on openjdk11 maybe I could try to remove totally gnome2 deps while trying to make ghidra work?

@jtojnar
Copy link
Contributor

jtojnar commented Dec 6, 2019

Do you know if the JavaFX/Swing/whatever is toolkit independent? Is the API abstract enough that apps do not have to care about which version of GTK are we using? If so removing gnome2 deps altogether would be a good idea.

@oneingan
Copy link
Contributor Author

oneingan commented Dec 6, 2019

Sorry but i don't know. i'm not very familiar with Java stuff. Anyways I feel confident to research and test it.

@stale
Copy link

stale bot commented Jun 3, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2020

Both gtk2/gtk3 is only a runtime dependency, not even a build dependency: https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/java-openjdk#n179
Therefor I think we could drop gtk2. It seems to be used for themes.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2020
@taku0
Copy link
Contributor

taku0 commented Dec 6, 2020

@taku0 taku0 mentioned this pull request Dec 12, 2020
13 tasks
@SuperSandro2000 SuperSandro2000 mentioned this pull request Apr 10, 2021
10 tasks
@oneingan
Copy link
Contributor Author

The main motivation for this change was to workaround a crash in Bisq software. Nowadays Bisq is working nice with vanilla openjdk11 as in latest nixpkgs commit.

So I close this PR because have big implications and require in-depth java knowledge.

@oneingan oneingan closed this Apr 12, 2021
@oneingan oneingan deleted the bisq branch April 12, 2021 11:58
@jtojnar jtojnar mentioned this pull request Apr 24, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants