Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onedrive: 2.3.10 -> 2.3.11 #73360

Merged
merged 2 commits into from Nov 13, 2019
Merged

onedrive: 2.3.10 -> 2.3.11 #73360

merged 2 commits into from Nov 13, 2019

Conversation

SRGOM
Copy link
Member

@SRGOM SRGOM commented Nov 13, 2019 •
edited by jonringer

Also, changed name to onedrive-abraunegg. Shows it's not official, and also gets tracked in repology for a potential auto-update using @ryantm 's bot.

Motivation for this change
  • Update
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ doronbehar

@SRGOM
onedrive: 2.3.10 -> 2.3.11
7134a1f 
Also, changed name to onedrive-abraunegg. Shows it's not official, and also gets tracked in repology for a potential auto-update using @ryantm 's bot.
@SRGOM
Copy link
Member Author

SRGOM commented Nov 13, 2019

I don't know how to make r-ryantm track this for autoupdate.... but I would find out and add it

@ofborg ofborg bot requested a review from doronbehar November 13, 2019 19:17
doronbehar
doronbehar reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@SRGOM
onedrive: 2.3.10 -> 2.3.11
8d682cc 
Address review comments
doronbehar
doronbehar approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for collaborating @SRGOM! BTW TBH, I don't use this package, I packaged it just because I considered using it so feel free not to wait for me the next time :)

@ofborg ofborg bot requested a review from doronbehar November 13, 2019 20:24
@SRGOM
Copy link
Member Author

SRGOM commented Nov 13, 2019

I'm helping myself... May I ask what you mean by 'so feel free not to wait for me the next time'?

I intend to try and submit a PR that adds a programs.onedrive.enable option to create a user service.

@doronbehar
Copy link
Contributor

'so feel free not to wait for me the next time' = Feel free to consider yourself as the "main" maintainer.

@SRGOM
Copy link
Member Author

SRGOM commented Nov 13, 2019

Alright, I guess I'll figure out how to add this to ryantm's auto updater

@jonringer
Copy link
Contributor

ryantm's auto updater will just scrap information from nix evaluations and try to bump the version and sha256 entries. Just need write it in a way that isn't specific to the version (E.g. some paths may have version information which would be invalid when updating.)

Essentially ryantm updates are free if you don't make assumptions about being a particular version.

jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73360
1 package were build:
onedrive

@jonringer jonringer merged commit 97a3671 into NixOS:master Nov 13, 2019
@jonringer
Copy link
Contributor

oh crap, forgot to look at commits... they should have been squashed

@SRGOM
Copy link
Member Author

SRGOM commented Nov 15, 2019 •
edited

I had to use the web interface to make these commits.
I'm going to sound like a luddite but how does one even make github commits with 2FA on? I used to just enter username and password earlier.

@fadenb
Copy link
Contributor

fadenb commented Nov 15, 2019

but how does one even make github commits with 2FA on? I used to just enter username and password earlier.

Use SSH key (no MFA), a personal access token (no MFA) or a client that supports their web-based login (I believe GiT for Windows does this)

@SRGOM
Copy link
Member Author

SRGOM commented Nov 15, 2019

personal token worked, thank you!

@SRGOM SRGOM mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SRGOM @doronbehar @jonringer @fadenb