Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadowenv: 1.2.1 -> 1.3.1 #73358

Merged
merged 1 commit into from Nov 14, 2019
Merged

shadowenv: 1.2.1 -> 1.3.1 #73358

merged 1 commit into from Nov 14, 2019

Conversation

burke
Copy link
Contributor

@burke burke commented Nov 13, 2019

Minor upstream changes, pretty much just adds a flag to shadowenv exec.

@ofborg ofborg bot requested a review from marsam November 13, 2019 18:35
jonringer
jonringer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[4 built, 36 copied (658.1 MiB), 215.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73358
1 package were build:
shadowenv

@jonringer
Copy link
Contributor

@GrahamcOfBorg build shadowenv

@marsam marsam merged commit 6ba2f55 into NixOS:master Nov 14, 2019
@marsam
Copy link
Contributor

marsam commented Nov 14, 2019

Thank you!

@burke burke deleted the shadowenv-131 branch November 18, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burke @jonringer @marsam