Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nftables: update build configuration #73331

Merged
merged 1 commit into from Nov 13, 2019
Merged

nftables: update build configuration #73331

merged 1 commit into from Nov 13, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 13, 2019 •
edited

Motivation for this change

Add custom options:

  • withDebugSymbols - build with debug symbols
  • withPython - build with python package

Fix error:
./configure: line 7055: /usr/bin/file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 13, 2019

cc @jonringer

@FRidh FRidh merged commit 705bafb into NixOS:master Nov 13, 2019
@Izorkin Izorkin deleted the nftables branch November 13, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @FRidh