Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argp-standalone: Find ar when cross compiling #73369

Merged
merged 1 commit into from Nov 14, 2019
Merged

argp-standalone: Find ar when cross compiling #73369

merged 1 commit into from Nov 14, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Nov 13, 2019 •
edited

Motivation for this change

I was trying to build rng-tools with musl. To do that, its dependencies also have to be built with musl.

cc @c0bw3b

Things done

Built it with nix-build -A pkgsCross.musl64.argp-standalone, which failed before.
Didn't test it because rng-tools still doesn't build because of other dependencies but this should cause any runtime changes.
The output of nix-build -A argp-standalone hashes to the same values as before.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Amar1729

@ofborg ofborg bot requested a review from Amar1729 November 13, 2019 23:58
Amar1729
Amar1729 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@Amar1729 Amar1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

c0bw3b
c0bw3b approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No regression on amd64 nixos

Result of nix-review pr 73369 1

2 package were build:
  • argp-standalone
  • rng-tools

@c0bw3b c0bw3b merged commit 5b57dd5 into NixOS:master Nov 14, 2019
@JohnAZoidberg JohnAZoidberg deleted the argp-standalone-cross branch November 14, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amar1729 Amar1729 Amar1729 approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @Amar1729 @c0bw3b