Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

celluloid: 0.17 -> 0.18 #73371

Merged
merged 2 commits into from Nov 14, 2019
Merged

celluloid: 0.17 -> 0.18 #73371

merged 2 commits into from Nov 14, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

https://github.com/celluloid-player/celluloid/releases/tag/v0.18

Been using git master for a bit since mpv 30 was released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
celluloid: 0.17 -> 0.18
453dd49 
Also don't sed out gtk-update-icon-cache, we have
setup to remove these caches.
@worldofpeace
celluloid: add worldofpeace to maintainers
79adfe9
@kolbycrouch
Copy link

Tested on recent nixos-unstable. looks good to me.

jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[10 built, 58 copied (149.6 MiB), 27.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73371
1 package were build:
celluloid

@jonringer jonringer merged commit 682930b into NixOS:master Nov 14, 2019
@worldofpeace worldofpeace deleted the update-celluloid branch November 14, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @kolbycrouch @jonringer