aws: data lifecycle manager #17
Conversation
PsyanticY
force-pushed
the
dlm
branch
3 times, most recently
from
2827ee2
to
8757231
Compare
PsyanticY
force-pushed
the
dlm
branch
2 times, most recently
from
5906388
to
e312148
Compare
|
@adisbladis Would you have a look at this pr, I am aware that it is conflicting but i would like to update it after checking your comments. |
PsyanticY
force-pushed
the
dlm
branch
3 times, most recently
from
cfeb816
to
f26ade2
Compare
| "ruleInterval", | ||
| "dlmName", | ||
| ] | ||
| dlm_diff = [k for k in dlm_keys if getattr(self, k) != config[k]] |
There was a problem hiding this comment.
@tewfik-ghariani the only remaining issue is here error: Value of type "AwsDataLifecycleManagerOptions" is not indexable
There was a problem hiding this comment.
getattr(config,k ) or something like "config.get(k)"
|
For the flack8 error if I fix it black check will fail |
|
It should be possible to use in-line ignoring
Ref : https://flake8.pycqa.org/en/latest/user/violations.html#in-line-ignoring-errors |
| , accessKeyId ? "testing" | ||
| , ... | ||
| }: | ||
| { |
There was a problem hiding this comment.
Please set the network attribute in the example file
network.description = "AWS DLM Testing";
Otherwise the evaluation would fail
error: attribute 'network' missing, at /home/tewfikghariani/.cache/pypoetry/virtualenvs/nixops-aws-oxCLMhSo-py3.8/lib/python3.8/site-packages/nix/eval-machine-info.nix:51:26
warning: evaluation of the deployment specification failed; status info may be incorrect
98faaf8
to
6ca4823
Compare
No description provided.