helpers: Fix broken fs image building #249
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sledges
reviewed
Nov 14, 2019
JamiKettunen
force-pushed
the
mic-build-fix
branch
from
ac7fb1f to
235a7e6
Compare
sledges
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is a very recent issue introduced by PR #247, which added support for building loop images. The grep command however wasn't implemented properly and thus it doesn't detect
droid-hal-*-kernel-modulesin patterns like it should due to a syntactical issue.This results in the assumption that a loop image shall be built and fails installing each package with
installing package X needs Y MB on the / filesystemspammed on screen.The exact same behavior has been seen by me and @nit-in already, but I'm pretty sure it would affect others too that do (local) mic builds after a dhd submodule update.
My solution simply fixes this mistake by using grep in extended regex mode while utilizing a logical or for the 2 different
DEVICEvalues inside regular brackets.