Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.black: fix build on darwin #73391

Merged
merged 1 commit into from Nov 14, 2019
Merged

python3Packages.black: fix build on darwin #73391

merged 1 commit into from Nov 14, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 14, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.black python37Packages.bugseverywhere python37Packages.cheroot python37Packages.cherrypy python37Packages.portend python37Packages.pyalgotrade python37Packages.pyls-black python37Packages.pytest-black python37Packages.stumpy python37Packages.uarray python37Packages.ws4py python37Packages.zerobin python38Packages.black python38Packages.bugseverywhere python38Packages.cheroot python38Packages.cherrypy python38Packages.git-revise python38Packages.portend python38Packages.pyalgotrade python38Packages.pytest-black

jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (failures broken on master)
diff LGTM

[29 built (4 failed), 243 copied (814.0 MiB), 232.0 MiB DL]
error: build of '/nix/store/gjgwl4sa77d1xqhxy5956v6v9lqpdzym-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73391
1 package are marked as broken and were skipped:
bareos

6 package failed to build:
ceph ceph-client libceph python38Packages.datasette python38Packages.pyls-black sambaFull

28 package were build:
datasette fava flexget git-revise mnemosyne python37Packages.black python37Packages.bugseverywhere python37Packages.cheroot python37Packages.cherrypy python37Packages.portend python37Packages.pyalgotrade python37Packages.pyls-black python37Packages.pytest-black python37Packages.stumpy python37Packages.uarray python37Packages.ws4py python37Packages.zerobin python38Packages.black python38Packages.bugseverywhere python38Packages.cheroot python38Packages.cherrypy python38Packages.git-revise python38Packages.portend python38Packages.pyalgotrade python38Packages.pytest-black python38Packages.uarray python38Packages.ws4py python38Packages.zerobin

@jonringer
Copy link
Contributor

failures are not related to this PR

Traceback (most recent call last):
  File "/private/tmp/nix-build-python3.7-cherrypy-18.3.0.drv-0/CherryPy-18.3.0/cherrypy/test/test_wsgi_unix_socket.py", line 46, in <lambda>
    atexit.register(lambda: os.remove(self.path))
FileNotFoundError: [Errno 2] No such file or directory: '/private/tmp/nix-build-python3.7-cherrypy-18.3.0.drv-0/tmpulg2xnrxcp_test.sock'

@jonringer jonringer merged commit 1ae55b8 into NixOS:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @jonringer