Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mendeley: Use Qt mkDerivation #73326

Merged
merged 1 commit into from Nov 13, 2019
Merged

mendeley: Use Qt mkDerivation #73326

merged 1 commit into from Nov 13, 2019

Conversation

alexarice
Copy link
Contributor

@alexarice alexarice commented Nov 13, 2019 •
edited

Motivation for this change
Things done

Make Mendeley use Qt's mkDerivation as I was getting the error,

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill

@alexarice alexarice changed the title mendeley: Use QT mkDerivation mendeley: Use Qt mkDerivation Nov 13, 2019
@alexarice
Copy link
Contributor Author

@GrahamcOfBorg build mendeley

@ofborg ofborg bot requested a review from dtzWill November 13, 2019 09:15
@alexarice
Copy link
Contributor Author

@NixOS/backports probably needs a backport to 19.09

worldofpeace
worldofpeace approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@worldofpeace
Copy link
Contributor

#65399

@worldofpeace worldofpeace merged commit c62c7b8 into NixOS:master Nov 13, 2019
@worldofpeace
Copy link
Contributor

backported in 16cb729.
Note, I missed something and had to apply a fixup on top of it 7c8b042.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexarice @worldofpeace