Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ef8c34c47217
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e6a37ef446f7
Choose a head ref
  • 13 commits
  • 13 files changed
  • 8 contributors

Commits on Nov 12, 2019

  1. pipenv: fix dependencies

    - setup_requires belong in nativeBuildInputs
    - requests is only for Python 2. We offer only a Python 3 version of
    pipenv
    - setting PYTHONPATH is not needed because the magical sed expression
    injects the dependencies in the executables. Otherwise, we would use
    NIX_PYTHONPATH.
    - PIP_IGNORE_INSTALLED was needed because of PYTHONPATH, but since we do
    not set that anymore we can remove.
    
    (cherry picked from commit 7f63ecf)
    FRidh committed Nov 12, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    bagder Daniel Stenberg
    Copy the full SHA
    dac9a00 View commit details
  2. pipenv: patch pipenv to point to python that has virtualenv

    (cherry picked from commit 1d7e219)
    FRidh committed Nov 12, 2019
    Copy the full SHA
    465e405 View commit details
  3. servant-client-core: patch a security issue leaking authorization header

    (cherry picked from commit f1682a7)
    Signed-off-by: Domen Kožar <domen@dev.si>
    domenkozar committed Nov 12, 2019
    Copy the full SHA
    195cbcc View commit details
  4. steam: Add libva to chrootenv

    After the newest update Steam itself complained about missing files
    and would not start:
    
    * libva.so.2
    * libva-x11.so.2
    
    (cherry picked from commit 5a13b85)
    baldo committed Nov 12, 2019
    Copy the full SHA
    4d114d2 View commit details
  5. Merge pull request #73281 from baldo/steam

    [19.09] steam: Add libva to chrootenv
    worldofpeace authored Nov 12, 2019
    Copy the full SHA
    975ad80 View commit details
  6. GCC 6: Fix java support

    Major version upper bound was one too low.
    Ericson2314 committed Nov 12, 2019
    Copy the full SHA
    903bdf1 View commit details
  7. Merge pull request #73292 from obsidiansystems/fix-gcj

    GCC 6: Fix java support for 19.09
    matthewbauer authored Nov 12, 2019
    Copy the full SHA
    1b524c2 View commit details
  8. eagle: use mkDerivation provided by qt5

    (cherry picked from commit a84607a)
    veprbl authored and worldofpeace committed Nov 12, 2019
    Copy the full SHA
    65eafbf View commit details
  9. Copy the full SHA
    a27a9b2 View commit details
  10. linux: 4.19.83 -> 4.19.84

    NeQuissimus committed Nov 12, 2019
    Copy the full SHA
    88af6a7 View commit details
  11. linux: 4.4.200 -> 4.4.201

    NeQuissimus committed Nov 12, 2019
    Copy the full SHA
    c1c96fd View commit details
  12. linux: 4.9.200 -> 4.9.201

    NeQuissimus committed Nov 12, 2019
    Copy the full SHA
    f136dbd View commit details
  13. linux: 5.3.10 -> 5.3.11

    NeQuissimus committed Nov 12, 2019
    Copy the full SHA
    e6a37ef View commit details
4 changes: 2 additions & 2 deletions pkgs/applications/science/electronics/eagle/eagle.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, makeDesktopItem
{ stdenv, mkDerivation, fetchurl, makeDesktopItem
, libXrender, libXrandr, libXcursor, libX11, libXext, libXi, libxcb
, libGL, glib, nss, nspr, expat, alsaLib
, qtbase, qtdeclarative, qtsvg, qtlocation, qtwebchannel, qtwebengine
@@ -11,7 +11,7 @@ let
qtbase qtdeclarative qtsvg qtlocation qtwebchannel qtwebengine
];
in
stdenv.mkDerivation rec {
mkDerivation rec {
pname = "eagle";
version = "9.4.2";

2 changes: 1 addition & 1 deletion pkgs/development/compilers/gcc/common/configure-flags.nix
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
}:

assert cloog != null -> stdenv.lib.versionOlder version "5";
assert langJava -> stdenv.lib.versionOlder version "6";
assert langJava -> stdenv.lib.versionOlder version "7";

let
inherit (stdenv)
6 changes: 3 additions & 3 deletions pkgs/development/haskell-modules/configuration-nix.nix
Original file line number Diff line number Diff line change
@@ -494,9 +494,9 @@ self: super: builtins.intersectAttrs super {
# https://github.com/plow-technologies/servant-streaming/issues/12
servant-streaming-server = dontCheck super.servant-streaming-server;

# https://github.com/haskell-servant/servant/pull/1128
servant-client-core = if (pkgs.lib.getVersion super.servant-client-core) == "0.15" then
appendPatch super.servant-client-core ./patches/servant-client-core-streamBody.patch
# https://github.com/haskell-servant/servant/pull/1238
servant-client-core = if (pkgs.lib.getVersion super.servant-client-core) == "0.16" then
appendPatch super.servant-client-core ./patches/servant-client-core-redact-auth-header.patch
else
super.servant-client-core;

Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
diff --git a/servant-client-core.cabal b/servant-client-core.cabal
index 5789da601..3faf65bb4 100644
--- a/servant-client-core.cabal
+++ b/servant-client-core.cabal
@@ -96,6 +96,7 @@ test-suite spec
main-is: Spec.hs
other-modules:
Servant.Client.Core.Internal.BaseUrlSpec
+ Servant.Client.Core.RequestSpec

-- Dependencies inherited from the library. No need to specify bounds.
build-depends:
diff --git a/src/Servant/Client/Core/Request.hs b/src/Servant/Client/Core/Request.hs
index 73756e702..0276d46f8 100644
--- a/src/Servant/Client/Core/Request.hs
+++ b/src/Servant/Client/Core/Request.hs
@@ -64,8 +64,32 @@ data RequestF body path = Request
, requestHeaders :: Seq.Seq Header
, requestHttpVersion :: HttpVersion
, requestMethod :: Method
- } deriving (Generic, Typeable, Eq, Show, Functor, Foldable, Traversable)
+ } deriving (Generic, Typeable, Eq, Functor, Foldable, Traversable)

+instance (Show a, Show b) =>
+ Show (Servant.Client.Core.Request.RequestF a b) where
+ showsPrec p req
+ = showParen
+ (p >= 11)
+ ( showString "Request {requestPath = "
+ . showsPrec 0 (requestPath req)
+ . showString ", requestQueryString = "
+ . showsPrec 0 (requestQueryString req)
+ . showString ", requestBody = "
+ . showsPrec 0 (requestBody req)
+ . showString ", requestAccept = "
+ . showsPrec 0 (requestAccept req)
+ . showString ", requestHeaders = "
+ . showsPrec 0 (redactSensitiveHeader <$> requestHeaders req))
+ . showString ", requestHttpVersion = "
+ . showsPrec 0 (requestHttpVersion req)
+ . showString ", requestMethod = "
+ . showsPrec 0 (requestMethod req)
+ . showString "}"
+ where
+ redactSensitiveHeader :: Header -> Header
+ redactSensitiveHeader ("Authorization", _) = ("Authorization", "<REDACTED>")
+ redactSensitiveHeader h = h
instance Bifunctor RequestF where bimap = bimapDefault
instance Bifoldable RequestF where bifoldMap = bifoldMapDefault
instance Bitraversable RequestF where
diff --git a/test/Servant/Client/Core/RequestSpec.hs b/test/Servant/Client/Core/RequestSpec.hs
new file mode 100644
index 000000000..99a1db7d3
--- /dev/null
+++ b/test/Servant/Client/Core/RequestSpec.hs
@@ -0,0 +1,19 @@
+{-# OPTIONS_GHC -fno-warn-orphans #-}
+{-# LANGUAGE OverloadedStrings #-}
+module Servant.Client.Core.RequestSpec (spec) where
+
+
+import Prelude ()
+import Prelude.Compat
+import Control.Monad
+import Data.List (isInfixOf)
+import Servant.Client.Core.Request
+import Test.Hspec
+
+spec :: Spec
+spec = do
+ describe "Request" $ do
+ describe "show" $ do
+ it "redacts the authorization header" $ do
+ let request = void $ defaultRequest { requestHeaders = pure ("authorization", "secret") }
+ isInfixOf "secret" (show request) `shouldBe` False

This file was deleted.

51 changes: 27 additions & 24 deletions pkgs/development/tools/pipenv/default.nix
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
{ lib
, buildPythonApplication
, flake8
, invoke
, parver
, pip
, requests
, virtualenv
, fetchPypi
, virtualenv-clone
, python3
}:

buildPythonApplication rec {
with python3.pkgs;

let

runtimeDeps = [
certifi
setuptools
pip
virtualenv
virtualenv-clone
];

pythonEnv = python3.withPackages(ps: with ps; [ virtualenv ]);

in buildPythonApplication rec {
pname = "pipenv";
version = "2018.11.26";

@@ -21,22 +27,19 @@ buildPythonApplication rec {

LC_ALL = "en_US.UTF-8";

propagatedBuildInputs = [
flake8
invoke
parver
pip
requests
virtualenv
virtualenv-clone
];
postPatch = ''
# pipenv invokes python in a subprocess to create a virtualenv
# it uses sys.executable which will point in our case to a python that
# does not have virtualenv.
substituteInPlace pipenv/core.py \
--replace "vistir.compat.Path(sys.executable).absolute().as_posix()" "vistir.compat.Path('${pythonEnv.interpreter}').absolute().as_posix()"
'';

doCheck = false;
nativeBuildInputs = [ invoke parver ];

makeWrapperArgs = [
"--set PYTHONPATH \".:$PYTHONPATH\""
"--set PIP_IGNORE_INSTALLED 1"
];
propagatedBuildInputs = runtimeDeps;

doCheck = false;

meta = with lib; {
description = "Python Development Workflow for Humans";
1 change: 1 addition & 0 deletions pkgs/games/steam/chrootenv.nix
Original file line number Diff line number Diff line change
@@ -75,6 +75,7 @@ in buildFHSUserEnv rec {
xorg.libX11
xorg.libXfixes
libGL
libva

# Not formally in runtime but needed by some games
at-spi2-atk
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/kernel/linux-4.14.nix
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
with stdenv.lib;

buildLinux (args // rec {
version = "4.14.153";
version = "4.14.154";

# modDirVersion needs to be x.y.z, will automatically add .0 if needed
modDirVersion = if (modDirVersionArg == null) then concatStrings (intersperse "." (take 3 (splitString "." "${version}.0"))) else modDirVersionArg;
@@ -13,6 +13,6 @@ buildLinux (args // rec {

src = fetchurl {
url = "mirror://kernel/linux/kernel/v4.x/linux-${version}.tar.xz";
sha256 = "08bsyawda0yjy4sgr817ich1xihm8c7dicns8bzk1pcpb884pfai";
sha256 = "00q662s8mgnzqfgk5gkzqfv9ws3vryf28blbq1zxcy4s6wj4mpl6";
};
} // (args.argsOverride or {}))
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/kernel/linux-4.19.nix
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
with stdenv.lib;

buildLinux (args // rec {
version = "4.19.83";
version = "4.19.84";

# modDirVersion needs to be x.y.z, will automatically add .0 if needed
modDirVersion = if (modDirVersionArg == null) then concatStrings (intersperse "." (take 3 (splitString "." "${version}.0"))) else modDirVersionArg;
@@ -13,6 +13,6 @@ buildLinux (args // rec {

src = fetchurl {
url = "mirror://kernel/linux/kernel/v4.x/linux-${version}.tar.xz";
sha256 = "1pahsqsjf2ylbx3nqf5a74n7a4cwmsqxdplqb7k23lkivw4lifh2";
sha256 = "0q06mhz170x1lkx6c6qdh82rcnsj03q6f2m28aqhmc4wc694m2w6";
};
} // (args.argsOverride or {}))
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/kernel/linux-4.4.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{ stdenv, buildPackages, fetchurl, perl, buildLinux, ... } @ args:

buildLinux (args // rec {
version = "4.4.200";
version = "4.4.201";
extraMeta.branch = "4.4";

src = fetchurl {
url = "mirror://kernel/linux/kernel/v4.x/linux-${version}.tar.xz";
sha256 = "02g8h62nq0xrfkxfxxwamdnmkw19p2x5lnrmqszlvgx1ymhfsnfm";
sha256 = "120kci4kmc48zcw16lhxmh71kaxm9ac5qxik36q3a20czg28b2m7";
};
} // (args.argsOverride or {}))
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/kernel/linux-4.9.nix
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{ stdenv, buildPackages, fetchurl, perl, buildLinux, ... } @ args:

buildLinux (args // rec {
version = "4.9.200";
version = "4.9.201";
extraMeta.branch = "4.9";

src = fetchurl {
url = "mirror://kernel/linux/kernel/v4.x/linux-${version}.tar.xz";
sha256 = "1z7gf36mh022nihdg4dlkdscr01jvbwikkm6jsbwcvdbv0s5qq2b";
sha256 = "125xmh5h1zmfniidpjljny53qkl4phpxaali69i66lajscxx8grq";
};
} // (args.argsOverride or {}))
4 changes: 2 additions & 2 deletions pkgs/os-specific/linux/kernel/linux-5.3.nix
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@
with stdenv.lib;

buildLinux (args // rec {
version = "5.3.10";
version = "5.3.11";

# modDirVersion needs to be x.y.z, will automatically add .0 if needed
modDirVersion = if (modDirVersionArg == null) then concatStrings (intersperse "." (take 3 (splitString "." "${version}.0"))) else modDirVersionArg;
@@ -13,6 +13,6 @@ buildLinux (args // rec {

src = fetchurl {
url = "mirror://kernel/linux/kernel/v5.x/linux-${version}.tar.xz";
sha256 = "08ls1nb0yw6apbx219wj4ax8mw57fjcp0496k2sz5sxhiywf0ql1";
sha256 = "1dxfh0l4inpjd17pyxfsskjsphs43r8lg6nhhr3y4whxdna5cwbf";
};
} // (args.argsOverride or {}))
2 changes: 1 addition & 1 deletion pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
@@ -8872,7 +8872,7 @@ in

pew = callPackage ../development/tools/pew {};
poetry = with python3Packages; toPythonApplication poetry;
pipenv = python3Packages.callPackage ../development/tools/pipenv {};
pipenv = callPackage ../development/tools/pipenv {};

pipewire = callPackage ../development/libraries/pipewire {};