Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus: 2.13.1 -> 2.14.0 #73339

Merged
merged 1 commit into from Nov 14, 2019
Merged

prometheus: 2.13.1 -> 2.14.0 #73339

merged 1 commit into from Nov 14, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 13, 2019

Motivation for this change

Changelog: https://github.com/prometheus/prometheus/releases/tag/v2.14.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Nov 13, 2019

@GrahamcOfBorg build prometheus

@fpletz
Copy link
Member

fpletz commented Nov 13, 2019

The tests are failing for me. An extra dependency is apparently needed.

running tests
compilation error :go: contrib.go.opencensus.io/exporter/ocagent@v0.6.0: Get https://proxy.golang.org/contrib.go.opencensus.io/exporter/ocagent/@v/v0.6.0.mod: dial tcp: lookup proxy.golang.org on [::1]:53: read udp [::1]:56691->[::1]:53: read: connection refused

FAIL    github.com/prometheus/prometheus/cmd/prometheus 0.096s
FAIL
builder for '/nix/store/f6lmxbn3fmjflh4x43dzlzj7m7r27fbk-prometheus-2.14.0.drv' failed with exit code 1
error: build of '/nix/store/f6lmxbn3fmjflh4x43dzlzj7m7r27fbk-prometheus-2.14.0.drv' failed

Why do they want to send data to opencensus.io anyway? 😱

@benley
Copy link
Member

benley commented Nov 13, 2019

Why do they want to send data to opencensus.io anyway?

I don't think that's what they're doing; opencensus is the tracing and metrics library that prometheus is using. It's just another OSS project.

@marsam
Copy link
Contributor Author

marsam commented Nov 14, 2019

the error happens because in buildGoPackage the go command tries to build the module in the checkPhase, and fails with invalid certificate. Fixed in #73380

@marsam
Copy link
Contributor Author

marsam commented Nov 14, 2019

I've added a fix until #73380 lands in master

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And the prometheus NixOS test succeeds.

@fpletz fpletz merged commit ee0c3b4 into NixOS:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants