Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freebayes: 2017-08-23 -> 1.3.1 (2019-06-03) #73340

Merged
merged 1 commit into from Nov 20, 2019
Merged

freebayes: 2017-08-23 -> 1.3.1 (2019-06-03) #73340

merged 1 commit into from Nov 20, 2019

Conversation

kwohlfahrt
Copy link
Contributor

Motivation for this change

Version bump.

A lot of the python scripts in result/bin can't be executed (before and after this change) because they don't find the interpreter. Should they be removed or left in place?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jdagilliland

@ofborg ofborg bot requested a review from jdagilliland November 13, 2019 13:25
@kwohlfahrt
Copy link
Contributor Author

Suggestion committed, should be good to go now.

@jonringer
Copy link
Contributor

do you mind squishing the change into the last commit?

git reset HEAD^
git add pkgs/
git commit --amend --no-edit
git push <fork> <branch> --force

@jonringer
Copy link
Contributor

https://nixos.org/nixpkgs/manual/#submitting-changes-submitting-changes

@kwohlfahrt
Copy link
Contributor Author

Done.

jonringer
jonringer approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM
executables still seem to work

[2 built, 2 copied (0.2 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73340
1 package were built:
freebayes

@jonringer jonringer merged commit 6b2504f into NixOS:master Nov 20, 2019
@kwohlfahrt kwohlfahrt deleted the freebayes branch December 18, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@jdagilliland jdagilliland Awaiting requested review from jdagilliland

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwohlfahrt @jonringer