meson: fix unknown compiler error #73423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This blocks the channel, should we promote this change to merge to master? While I don't really agree with the i686 minimal iso blocking the channel 93aa83d, I'm guessing we might also need to change nixos-channel-scripts. |
worldofpeace
approved these changes
Nov 14, 2019
|
Probably. Will deal with the merge conflict later. |
|
Another thing is we don't even CI i686-linux. So we don't even check we're breaking things, while having this artifact being a channel blocker. |
jtojnar
force-pushed
the
meson-icl-fix
branch
from
b69a3bc
to
3108c4d
Compare
jtojnar
requested review from
basvandijk,
cdepillabout,
edwtjo,
FRidh,
infinisil,
jonringer,
matthewbauer,
peti and
thoughtpolice
as code owners
jtojnar
removed request for
thoughtpolice,
matthewbauer,
peti,
edwtjo,
cdepillabout and
ttuegel
jtojnar
removed request for
basvandijk,
FRidh,
jonringer,
WilliButz and
infinisil
|
Still having it as a channel blocker was kind of a trade-off. We did not really want to drop i686 entirely, but still have a minimum set of packages working. See #27923 and the references in it. |
|
That's over 2 years ago already. Maybe we can revisit it again. Somehow I think there is still a userbase for i686. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #73417