haskellPackages.llvm-hs: fix build on darwin #73434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm-hs
is broken on darwin. This PR fixes it.There is a thread on discourse where I investigated why it was broken:
https://discourse.nixos.org/t/how-to-get-llvm-hs-building-on-macosx-in-nixpkgs/4780
@ElvishJerricco suggested a simple fix, and in trying it I came up with something relatively simple that worked.
Motivation for this change
llvm-hs's Setup.hs file tries to add the
lib/
directory from LLVM8 to theDYLD_LIBRARY_PATH
environment variable. This messes up clang when called from GHC, probably because clang is version 7, but we are using LLVM8.This PR patches the
Setup.hs
file to not modify theDYLD_LIBRARY_PATH
environment variable.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @peti