Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.llvm-hs: fix build on darwin #73434

Merged
merged 1 commit into from Nov 15, 2019

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Nov 15, 2019

llvm-hs is broken on darwin. This PR fixes it.

There is a thread on discourse where I investigated why it was broken:

https://discourse.nixos.org/t/how-to-get-llvm-hs-building-on-macosx-in-nixpkgs/4780

@ElvishJerricco suggested a simple fix, and in trying it I came up with something relatively simple that worked.

Motivation for this change

llvm-hs's Setup.hs file tries to add the lib/ directory from LLVM8 to the DYLD_LIBRARY_PATH environment variable. This messes up clang when called from GHC, probably because clang is version 7, but we are using LLVM8.

This PR patches the Setup.hs file to not modify the DYLD_LIBRARY_PATH environment variable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peti

@peti peti merged this pull request into NixOS:haskell-updates Nov 15, 2019
@cdepillabout cdepillabout deleted the llvm-hs-fix branch November 16, 2019 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants