Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmrig: 3.2.0 -> 5.0.0 #73433

Merged
merged 1 commit into from Nov 17, 2019
Merged

xmrig: 3.2.0 -> 5.0.0 #73433

merged 1 commit into from Nov 17, 2019

Conversation

kim0
Copy link
Contributor

@kim0 kim0 commented Nov 15, 2019

Motivation for this change

xmrig: 3.2.0 -> 5.0.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz

@kim0
Copy link
Contributor Author

kim0 commented Nov 15, 2019

cc @volth @vcunat

@kim0
Copy link
Contributor Author

kim0 commented Nov 15, 2019

ping @Mic92 .. You just merged my other PR xmrig-proxy, could you please merge this one too. Thanks

Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fpletz fpletz merged commit f394b56 into NixOS:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants