Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] davmail: 5.2.0 -> 5.4.0 #73413

Merged
merged 1 commit into from Nov 14, 2019
Merged

[19.09] davmail: 5.2.0 -> 5.4.0 #73413

merged 1 commit into from Nov 14, 2019

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Nov 14, 2019

Backport of #73333
(cherry picked from commit 5388153)

New release contains bug/security fixes.

Motivation for this change
Things done

Tested this locally with the existing davmail module. Seems to be working fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jonringer

davmail: 5.2.0 -> 5.4.0
6e28296 
(cherry picked from commit 5388153)

New release contains bug/security fixes.
jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
gui launches fine

[2 built, 1 copied (0.5 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73413
1 package were build:
davmail

@jonringer jonringer merged commit 9705b6b into NixOS:release-19.09 Nov 14, 2019
@fadenb fadenb deleted the 19.09_davmail_5.4.0 branch November 14, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fadenb @jonringer