Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chez-matchable: init at 1.0 #73419

Merged
merged 2 commits into from Dec 11, 2019
Merged

chez-matchable: init at 1.0 #73419

merged 2 commits into from Dec 11, 2019

Conversation

jitwit
Copy link
Contributor

@jitwit jitwit commented Nov 14, 2019 •
edited

Motivation for this change

Adding a package definition for the hygenic pattern matching library developed by Alex Shinn.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Lassulus
Lassulus reviewed Nov 17, 2019
View reviewed changes
pkgs/development/chez-modules/chez-matchable/default.nix Outdated
pname = "chez-matchable";
version = "1.0";

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use fetchFromGitHub here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchFromGitHub fetches the tarball from github, which makes downloads faster

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, done! (assuming it looks ok now?)

doronbehar
doronbehar requested changes Dec 6, 2019
View reviewed changes
pkgs/development/chez-modules/chez-matchable/default.nix Outdated

src = fetchgit {
url = "https://github.com/fedeinthemix/chez-matchable.git";
rev = "73e46432ae70ec72eba6ef116bd84ad9ee38b2f2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please use the version as the rev - the Git tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Otherwise it's ok?

Lassulus
Lassulus approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds with nix-review, LGTM

EDIT: wait, the version is not 1.0 anymore, can you change the commit message?
EDIT EDIT: ah nvm, I can change it when squasing

@Lassulus Lassulus merged commit bbd6003 into NixOS:master Dec 11, 2019
@jitwit
Copy link
Contributor Author

jitwit commented Dec 11, 2019

builds with nix-review, LGTM

EDIT: wait, the version is not 1.0 anymore, can you change the commit message?
EDIT EDIT: ah nvm, I can change it when squasing

Ach, sorry for missing that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar requested changes

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jitwit @Lassulus @doronbehar