Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "python37Packages.pyspf: 2.0.12 -> 2.0.13" #73427

Merged
merged 1 commit into from Nov 15, 2019
Merged

Revert "python37Packages.pyspf: 2.0.12 -> 2.0.13" #73427

merged 1 commit into from Nov 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 14, 2019

This reverts commit e3f9c4d.
This fixes #72791.
Version 2.0.13 introduced a bug where some incoming mails can cause a
crash and be falsely rejected. (sdgathman/pyspf#17)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@ghost ghost requested review from FRidh and jonringer as code owners November 14, 2019 22:54
@FRidh
Copy link
Member

FRidh commented Nov 14, 2019

Could you include a comment next to the version info that 2.0.13 should not be used. That way we likely notice it when the bot proposes the change again.

@ofborg ofborg bot requested a review from abbradar November 14, 2019 23:11
@ghost
Copy link
Author

ghost commented Nov 14, 2019

Could you include a comment next to the version info that 2.0.13 should not be used. That way we likely notice it when the bot proposes the change again.

Good idea, done.

Revert "python37Packages.pyspf: 2.0.12 -> 2.0.13"
00a3aa9 
This reverts commit e3f9c4d.
This fixes #72791.
Version 2.0.13 of pyspf introduced a bug where some incoming mails can cause a
crash and be falsely rejected. (sdgathman/pyspf#17)
jonringer
jonringer approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
intention seems reasonable

https://github.com/NixOS/nixpkgs/pull/73427
4 package were build:
pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pypolicyd-spf python27Packages.pyspf python37Packages.pyspf python38Packages.pyspf

@jonringer jonringer merged commit dafbcb9 into NixOS:master Nov 15, 2019
infinisil added a commit to infinisil/system that referenced this pull request Nov 18, 2019
@infinisil
Fix policy-spf mail server thing
2a58e84 
NixOS/nixpkgs#73427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postfix policyd-spf issuing traceback on incoming mail, mails being falsely rejected
2 participants
@FRidh @jonringer