New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/xserver:services.xserver.xkbOptions is now commas #73394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't break any functionality (see xkbvalidate) and makes the the option mergable. 👍
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This is a breaking change right? If so, maybe a changelog entry would be good. Also as a minor nitpick: Please use the imperative in your commit message and talk about your intention, not the implementation details ( CC @Ericson2314 |
No, it shouldn't break any existing module or config:
However if two modules set |
Nice. I don't have much experience with NixOS modules, so thanks for clarifying. Since @Ericson2314 raised the initial issue and has merge rights himself, I think its best if he takes a look at this and ultimately merges it. If he's unresponsive for a couple of days feel free to ping me again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pasqui23 I'm seeing of a lot of your commits getting merged in like
title:commit description
when there's a missing space.
Can we do?
nixos/xserver: xkbOptions is now commas
@pasqui23 Do you know how you can change the commit description the way @worldofpeace suggests? If not, |
Thank you @pasqui23 ! |
Motivation for this change
Fixes #18646
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @