Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkcert: 1.4.0 -> 1.4.1 #73395

Merged
merged 1 commit into from Nov 24, 2019
Merged

mkcert: 1.4.0 -> 1.4.1 #73395

merged 1 commit into from Nov 24, 2019

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Nov 14, 2019 •
edited

Motivation for this change

mkcert@v1.4.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @marsam

This change is Reviewable

@ofborg ofborg bot requested review from ehmry and marsam November 14, 2019 14:44
@Br1ght0ne @jonringer
mkcert: 1.4.0 -> 1.4.1
48ba169 
Co-authored-by: Joh <jonringer@users.noreply.github.com>
@Br1ght0ne Br1ght0ne marked this pull request as ready for review November 14, 2019 17:34
@ofborg ofborg bot requested a review from kalbasit November 14, 2019 17:51
@jonringer
Copy link
Contributor

@marsam what was the original motivation from going from a module to package in the last bump?

@marsam marsam merged commit 24f7357 into NixOS:master Nov 24, 2019
@marsam
Copy link
Contributor

marsam commented Nov 24, 2019 •
edited

Sorry for the late response

what was the original motivation from going from a module to package in the last bump?

buildGoModule is a fixed-output derivation which which might not be preferable NixOS/nix#2270; when a package vendorizes its dependencies (vendor directory) we can use buildGoPackage without holding a deps.nix.
mkcert recently embraced go modules, and removed its vendorized dependencies

@Br1ght0ne Br1ght0ne deleted the mkcert-1.4.1 branch November 24, 2019 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@marsam marsam Awaiting requested review from marsam

@jonringer jonringer Awaiting requested review from jonringer

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Br1ght0ne @jonringer @marsam