Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

richgo: 0.2.8 -> 0.3.3 #73431

Merged
merged 1 commit into from Nov 24, 2019
Merged

richgo: 0.2.8 -> 0.3.3 #73431

merged 1 commit into from Nov 24, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kalbasit

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build richgo

@ofborg ofborg bot requested a review from kalbasit November 15, 2019 00:04
Lassulus
Lassulus approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit 6acbcff into NixOS:master Nov 24, 2019
@rvolosatovs rvolosatovs deleted the update/richgo branch December 3, 2019 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rvolosatovs @Lassulus