So this only applies to 19.03? Can you document that in the commit message?

I think it was fixed similarly in mainline: d57d67e - I'll add this info to the commit message.

The v17 version of cherrypy we have is still broken on 19.09 and master. There are several packages broken on 19.09 due to this. Master on the other hand I think has indirectly v17 disabled likely due to a phasing out of python2 in preparation for it's 2020 EOL. Edit: Maybe not, but it isn't being built by hydra

Both the patch on this PR and the one in d57d67e when ported fix release-19.09 (and likely master too if it was possible to build)

I see that python37 build works on hydra for darwin https://hydra.nixos.org/build/106807015 the python38 build seems to be broken by aiohttp

Is this still relevant?

I would say no, 19.09 is already near EOL, and 20.03 is about to be released.

@risicle thank you for opening the PR though :)

@jonringer This is all implied of course. I was thinking that we should not completely discourage motivated individuals from backporting fixes to the older releases. However, they should keep in mind that: first, they would need to do most of the work of proving that the changes are safe, and, second, that the EOL channels often get blocked and may not advance to the newer commits without some additional fixes to other parts of NixOS.

I completely agree.

If this was targeting the 19.09 branch, i would have reviewed and merged as usual. But currently if someone were to raise an issue against 19.03, we would likely tell the use to use 19.09 as 19.03 is no longer supported