Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Celestial trajectory plotting #2370

Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Nov 9, 2019

This pull request makes the Max history length setting hide history, instead of forgetting it. It does not introduce a separate setting to forget the history; we may want to add that if people complain about performance issues.

Fix #942.
Fix #2164.

All hail retrobop:
screenshot18

Epicycles:
screenshot20

Short histories:
screenshot21
screenshot22

Miscellaneous screenshots:
screenshot11
screenshot12
screenshot13
screenshot14
screenshot15
screenshot16
screenshot17

char const* const vessel_guid,
double const max_history_length) {
journal::Method<journal::PlanetariumPlotPsychohistory> m(
{planetarium, plugin, method, vessel_guid, max_history_length});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the original formatting: we generally put the parameters in a single column as it helps making sure that they match the profile of the method.

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generally put the parameters in a single column as it helps making sure that they match the profile of the method.

We don't do that where it doesn't fit to the right of m. Here it doesn't fit.

Sorry, something went wrong.

char const* const vessel_guid,
double const max_history_length) {
journal::Method<journal::PlanetariumPlotCelestialTrajectoryForPsychohistory>
m({planetarium, plugin, celestial_index, vessel_guid, max_history_length});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameters in column.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same.

char const* const vessel_guid,
double const max_history_length) {
journal::Method<journal::PlanetariumPlotPsychohistory> m(
{planetarium, plugin, method, vessel_guid, max_history_length});
CHECK_NOTNULL(plugin);
CHECK_NOTNULL(planetarium);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably check vessel_guid too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do that everywhere in this file, but that's a job for a separate pull request.

ksp_plugin/interface_planetarium.cpp Outdated Show resolved Hide resolved
ksp_plugin/interface_planetarium.cpp Show resolved Hide resolved
ksp_plugin/planetarium.cpp Outdated Show resolved Hide resolved
ksp_plugin/planetarium.hpp Show resolved Hide resolved
ksp_plugin_adapter/gl_lines.cs Show resolved Hide resolved
return;
}
celestial.orbitDriver.Renderer.drawMode =
main_window_.display_patched_conics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why we still have that option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly comparing with stock, for our entertainment.

ksp_plugin_adapter/ksp_plugin_adapter.cs Outdated Show resolved Hide resolved
@pleroy pleroy added the LGTM label Nov 16, 2019
@eggrobin eggrobin merged commit f3d4abd into mockingbirdnest:master Nov 16, 2019
@eggrobin eggrobin mentioned this pull request Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hiding histories instead of forgetting them Draw celestial body orbits
2 participants