-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Celestial trajectory plotting #2370
Celestial trajectory plotting #2370
Conversation
char const* const vessel_guid, | ||
double const max_history_length) { | ||
journal::Method<journal::PlanetariumPlotPsychohistory> m( | ||
{planetarium, plugin, method, vessel_guid, max_history_length}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the original formatting: we generally put the parameters in a single column as it helps making sure that they match the profile of the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generally put the parameters in a single column as it helps making sure that they match the profile of the method.
We don't do that where it doesn't fit to the right of m
. Here it doesn't fit.
ksp_plugin/interface_planetarium.cpp
Outdated
char const* const vessel_guid, | ||
double const max_history_length) { | ||
journal::Method<journal::PlanetariumPlotCelestialTrajectoryForPsychohistory> | ||
m({planetarium, plugin, celestial_index, vessel_guid, max_history_length}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parameters in column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same.
char const* const vessel_guid, | ||
double const max_history_length) { | ||
journal::Method<journal::PlanetariumPlotPsychohistory> m( | ||
{planetarium, plugin, method, vessel_guid, max_history_length}); | ||
CHECK_NOTNULL(plugin); | ||
CHECK_NOTNULL(planetarium); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably check vessel_guid
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do that everywhere in this file, but that's a job for a separate pull request.
colour.a = 1 - (float)(4 * index) / (float)(5 * size); | ||
UnityEngine.GL.Color(colour); | ||
var faded_colour = colour; | ||
faded_colour.a *= 1 - (float)(4 * index) / (float)(5 * size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment this formula. I'm not sure what the *=
is doing.
return; | ||
} | ||
celestial.orbitDriver.Renderer.drawMode = | ||
main_window_.display_patched_conics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why we still have that option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly comparing with stock, for our entertainment.
This pull request makes the
Max history length
setting hide history, instead of forgetting it. It does not introduce a separate setting to forget the history; we may want to add that if people complain about performance issues.Fix #942.
Fix #2164.
All hail retrobop:

Epicycles:

Short histories:


Miscellaneous screenshots:






