Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnix: 1.8.2 -> 1.9.1 #73410

Merged
merged 1 commit into from Nov 14, 2019
Merged

vulnix: 1.8.2 -> 1.9.1 #73410

merged 1 commit into from Nov 14, 2019

Conversation

ckauhaus
Copy link
Contributor

Motivation for this change

Upstream release. The old version is broken because NIST has discontinued NVD XML feeds. vulnix 1.9.x uses the JSON feeds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): 280948800 -> 225478136 (reduction!)
  • Ensured that relevant documentation is up to date -> discussion going on in Open questions regarding security fixes #73342
  • Fits CONTRIBUTING.md.
Notify maintainers

[ckauhaus] I don't want to merge my own PR. Would someone please review this? TIA

vulnix: 1.8.2 -> 1.9.1
bd9c5be 
New upstream release. The old version is broken because NIST has
discontinued NVD XML feeds. vulnix 1.9.x uses the JSON feeds.
jonringer
jonringer approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executables show usage

[3 built, 28 copied (60.5 MiB), 12.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73410
1 package were build:
vulnix

@jonringer
Copy link
Contributor

@GrahamcOfBorg build vulnix

@jonringer jonringer merged commit be83d68 into NixOS:master Nov 14, 2019
@ckauhaus ckauhaus deleted the vulnix-1-9-1 branch November 16, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ckauhaus @jonringer