New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackage.ovirt-engine-sdk: init at 4.3.3 #73372
Conversation
maintainers/maintainer-list.nix
Outdated
@@ -1411,6 +1411,12 @@ | |||
githubId = 411324; | |||
name = "Carles Pagès"; | |||
}; | |||
cptMikky = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be a separate commit before the package addition:
maintainers: add cptMikky
@@ -0,0 +1,31 @@ | |||
{ lib, buildPythonPackage, fetchPypi, pkgs }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please import libxml directly
{ lib, buildPythonPackage, fetchPypi, pkgs }: | |
{ lib, buildPythonPackage, fetchPypi, libxml2 }: |
]; | ||
|
||
prePatch = '' | ||
substituteInPlace setup.py --replace "/usr/include/libxml2" "${pkgs.libxml2.dev}/include/libxml2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case dev output gets removed (unlikely)
substituteInPlace setup.py --replace "/usr/include/libxml2" "${pkgs.libxml2.dev}/include/libxml2" | |
substituteInPlace setup.py --replace "/usr/include/libxml2" "${lib.getDev libxml2}/include/libxml2" |
pkgs/top-level/python-packages.nix
Outdated
@@ -834,6 +834,8 @@ in { | |||
|
|||
outcome = callPackage ../development/python-modules/outcome {}; | |||
|
|||
ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk {}; | |
ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk { | |
inherit (pkgs) libxml2; | |
}; |
and squash the license change into the package commit as well please :) |
329a8fc
to
cea6e16
Compare
sha256 = "0hz7rcz7l391n8ixcwvqw3iq5bx26fk9l5c6xxymv036zm3r9pnh"; | ||
}; | ||
|
||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly, I just copy-pasted this derivation from some other package. Not sure what the tests do but I can enable them
|
||
doCheck = false; | ||
|
||
buildInputs = with pkgs.python37Packages; [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python packages are not often in buildInputs
. This would imply the Python packages in this list are only needed during build-time and not run-time. Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, not correct - I misunderstood the buildInputs behavior, will fix, thanks
closing in favor of #73389 |
Motivation for this change
Ansible ovirt_* modules require this lib
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @