Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackage.ovirt-engine-sdk: init at 4.3.3 #73372

Closed
wants to merge 2 commits into from

Conversation

jficz
Copy link
Contributor

@jficz jficz commented Nov 14, 2019

Motivation for this change

Ansible ovirt_* modules require this lib

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@@ -1411,6 +1411,12 @@
githubId = 411324;
name = "Carles Pagès";
};
cptMikky = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a separate commit before the package addition:

maintainers: add cptMikky

@@ -0,0 +1,31 @@
{ lib, buildPythonPackage, fetchPypi, pkgs }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import libxml directly

Suggested change
{ lib, buildPythonPackage, fetchPypi, pkgs }:
{ lib, buildPythonPackage, fetchPypi, libxml2 }:

];

prePatch = ''
substituteInPlace setup.py --replace "/usr/include/libxml2" "${pkgs.libxml2.dev}/include/libxml2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case dev output gets removed (unlikely)

Suggested change
substituteInPlace setup.py --replace "/usr/include/libxml2" "${pkgs.libxml2.dev}/include/libxml2"
substituteInPlace setup.py --replace "/usr/include/libxml2" "${lib.getDev libxml2}/include/libxml2"

@@ -834,6 +834,8 @@ in {

outcome = callPackage ../development/python-modules/outcome {};

ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk {};
ovirt-engine-sdk = callPackage ../development/python-modules/ovirt-engine-sdk {
inherit (pkgs) libxml2;
};

@jonringer
Copy link
Contributor

and squash the license change into the package commit as well please :)

sha256 = "0hz7rcz7l391n8ixcwvqw3iq5bx26fk9l5c6xxymv036zm3r9pnh";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the tests disabled? Include a comment in the expression explaining why the tests are disabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly, I just copy-pasted this derivation from some other package. Not sure what the tests do but I can enable them


doCheck = false;

buildInputs = with pkgs.python37Packages; [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python packages are not often in buildInputs. This would imply the Python packages in this list are only needed during build-time and not run-time. Is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, not correct - I misunderstood the buildInputs behavior, will fix, thanks

@jficz jficz closed this Nov 14, 2019
@jficz
Copy link
Contributor Author

jficz commented Nov 14, 2019

closing in favor of #73389

@jficz jficz deleted the ovirt-engine-sdk branch November 14, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants