New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/ttyd: init #68604
Merged
Merged
nixos/ttyd: init #68604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Sep 20, 2019
atopuzov
force-pushed
the
ttyd-service
branch
3 times, most recently
from
September 21, 2019 10:42
2397818
to
bf6b062
Compare
atopuzov
force-pushed
the
ttyd-service
branch
from
October 15, 2019 15:29
bf6b062
to
11879ee
Compare
infinisil
requested changes
Oct 29, 2019
atopuzov
force-pushed
the
ttyd-service
branch
4 times, most recently
from
November 11, 2019 19:01
0742675
to
903bb3b
Compare
infinisil
requested changes
Nov 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind, but I found one more security-sensitive thing to address. Once that's addressed I think this can be merged
atopuzov
force-pushed
the
ttyd-service
branch
from
November 13, 2019 23:19
903bb3b
to
6b3cc03
Compare
It's all good, good to learn and make NixOs better. |
infinisil
approved these changes
Nov 14, 2019
Looking good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I have been using shellinabox but the terminal implementation leaves something to be desired. And since ttyd is already in nixpkgs i decided to give it a go and write a module for it.
TLDR:
ttyd enables you (like shellinabox) to expose a shell over a websocket.
Tested out on nixos 19.03 by including this module and adding ttyd to pkgs in override.
Sample service configuration:
Relevant part of the nginx configuration
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @