Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapGAppsHook: add wrapGApp helper #68402

Merged
merged 5 commits into from Sep 10, 2019
Merged

wrapGAppsHook: add wrapGApp helper #68402

merged 5 commits into from Sep 10, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 10, 2019

For parity with Qt.

@worldofpeace

This comment has been minimized.

using indirect variable access must be better than eval
These should not cause issues in practice but it is good idea to handle them.

* prefix and targetOffset are mandatory, as they are always set by the generic builder.
* wrapPrefixVariables and dontWrapGApps are now defaulting to empty value, as they are not mandatory.
@jtojnar

This comment has been minimized.

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Sep 10, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@jtojnar jtojnar merged commit a0ec91d into NixOS:staging Sep 10, 2019
@jtojnar jtojnar deleted the better-wgah branch September 10, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants