Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi-password: init at 0.1.0 #68373

Merged
merged 2 commits into from Sep 9, 2019
Merged

wifi-password: init at 0.1.0 #68373

merged 2 commits into from Sep 9, 2019

Conversation

nikitavoloboev
Copy link
Contributor

Motivation for this change

Package I use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

Co-Authored-By: symphorien <symphorien@users.noreply.github.com>
@zimbatm zimbatm merged commit 8b75a0a into NixOS:master Sep 9, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 18, 2019
* wifi-password: init at 0.1.0

* Apply suggestions from code review

Co-Authored-By: symphorien <symphorien@users.noreply.github.com>
(cherry picked from commit 8b75a0a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants