Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citrix-receiver: decomission in favor of citrix-workspace. #68372

Merged
merged 1 commit into from Sep 14, 2019
Merged

citrix-receiver: decomission in favor of citrix-workspace. #68372

merged 1 commit into from Sep 14, 2019

Conversation

obadz
Copy link
Contributor

@obadz obadz commented Sep 9, 2019 •
edited

Already documented in #64645

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ma27 @FRidh

Ma27
Ma27 reviewed Sep 9, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself seems fine 👍

But can you please mention this in the changelog for 19.09 and remove the references to citrix_receiver in doc/package-specific-user-notes.xml? :)

@lheckemann
Copy link
Member

Should this be backported to 19.09?

@Ma27
Copy link
Member

Ma27 commented Sep 10, 2019

Yes since citrix-receiver 13.10 for Linux will be EOLed in december 2019: https://www.citrix.de/support/product-lifecycle/milestones/receiver.html

Would've done it anyway as soon as my review is addressed :)

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 10, 2019
@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@obadz
Copy link
Contributor Author

obadz commented Sep 14, 2019

@Ma27, updated as requested.

@Ma27 Ma27 self-assigned this Sep 14, 2019
@Ma27 Ma27 merged commit 5d85316 into NixOS:master Sep 14, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 14, 2019

Thanks! Backported as aac9559.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 14, 2019
@obadz obadz deleted the citrix-receiver-decomission branch April 21, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees

@Ma27 Ma27

Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@obadz @lheckemann @Ma27 @FRidh