Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for "wpt-pr-bot" in docs doesn't find the page mentioning it #18943

Open
foolip opened this issue Sep 9, 2019 · 4 comments
Open

Searching for "wpt-pr-bot" in docs doesn't find the page mentioning it #18943

foolip opened this issue Sep 9, 2019 · 4 comments
Labels

Comments

@foolip
Copy link
Member

foolip commented Sep 9, 2019

This search: https://web-platform-tests.org/search.html?q=wpt-pr-bot&check_keywords=yes&area=default

Should find this page: https://web-platform-tests.org/admin/index.html

It does not.

@jugglinmike are not all pages indexed?

@foolip foolip added the docs label Sep 9, 2019
@zcorpan
Copy link
Member

zcorpan commented Sep 9, 2019

Searching for "bot" finds that page, so it should be indexed.

Searching for "w3c-test" highlights "w3c" but not "test" in "w3c-test", suggesting this may be a bug in the keyword matching.

@zcorpan
Copy link
Member

zcorpan commented Sep 9, 2019

This could be sphinx-doc/sphinx#1486 (comment) (though searching for two words with a space between seems to work, now)

@foolip
Copy link
Member Author

foolip commented Sep 9, 2019

I wonder how hard it would be to also search by exact substring match? Is the sphinx search thing at all configurable, or is this what we get unless we want to fork sphinx?

@zcorpan
Copy link
Member

zcorpan commented Sep 9, 2019

I found an old PR that claims

Sample regex above allows users to search for strings containing these punctuation characters: \, /, :, ., and -.

We could try to apply that patch and see if it fixes this, and if so try to get it merged in sphinx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants