Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

melpaPackages.elpy: bugfix #68376

Merged
merged 1 commit into from
Sep 12, 2019
Merged

melpaPackages.elpy: bugfix #68376

merged 1 commit into from
Sep 12, 2019
+0 −5

Conversation

wildsebastian
Copy link
Contributor

@wildsebastian wildsebastian commented Sep 9, 2019 •
edited
Loading

Motivation for this change

After the elpy dummy package was removed (#68217) it was still referenced
in the melpa packages and broke emacs builds that included elpy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 9, 2019
@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@talyz
Copy link
Contributor

talyz commented Sep 12, 2019

Thanks for fixing this! The reference in all-packages.nix, inherit (pythonPackages) elpy;, should also be dropped to get rid of any trace of the old python package. It's currently at line 17965; GitHub won't let me reference it - the file seems to be too big.

@wildsebastian
melpaPackages.elpy: bugfix

Unverified

No user is associated with the committer email.
Learn about vigilant mode
458e3c7 
After the elpy dummy package was removed (NixOS#68217) it was still referenced
in the melpa packages and broke emacs builds that included elpy.
@wildsebastian
Copy link
Contributor Author

You are welcome! Thank you, I missed that spot. I fixed it and updated the pull request.

@adisbladis adisbladis merged commit 76e4d0e into NixOS:master Sep 12, 2019
@adisbladis
Copy link
Member

Thank you :)

@ashgillman
Copy link
Contributor

Is this still a bug in 19.09?

sudo nixos-rebuild boot --upgrade                                                                                                                                   
unpacking channels...                                                                
building Nix...                                                                 
building the system configuration...                      
error: attribute 'elpy' missing, at /nix/store/ddipzj8c08yxsxk8vh2hq0ppl13756zz-nixos-19.09.1861.eb65d1dae62/nixos/pkgs/top-level/all-packages.nix:17991:17             
(use '--show-trace' to show detailed location information)

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis

Assignees
No one assigned
Labels
6.topic: emacs Text editor 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wildsebastian @talyz @adisbladis @ashgillman @lheckemann @Janik-Haag