Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appleseed: fix build #68388

Merged
merged 1 commit into from Sep 13, 2019
Merged

appleseed: fix build #68388

merged 1 commit into from Sep 13, 2019

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Sep 9, 2019

Motivation for this change

My first PR of #68361! There was a new version available, but it needs some dependency updates so I’ll do that separately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alyssais alyssais added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 9, 2019
@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@lheckemann lheckemann self-assigned this Sep 13, 2019
@lheckemann lheckemann merged commit 39ee746 into NixOS:master Sep 13, 2019
@lheckemann
Copy link
Member

backported: 309cdb8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lheckemann lheckemann

Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @lheckemann