Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gnome3: add gnome-shell xdg portal #68390

Merged
merged 1 commit into from Sep 10, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

I was looking at the build output of gnome-shell and noticed there was a portal.
This could have been causing some issues not being added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar
Copy link
Contributor

jtojnar commented Sep 9, 2019

@worldofpeace
Copy link
Contributor Author

Also only used for sandboxed applications

If a sandboxed app requests access to some system resource (camera,
microphone, location), the portal frontend needs to ask the user
for permission. In GNOME, we want this to be a system modal dialog,
so provide an org.freedesktop.impl.portal.access implementation
that exposes a generic system modal permission dialog on the bus.

So likely there was no access dialog working with flatpak apps before this change.

@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
@worldofpeace worldofpeace merged commit e997860 into NixOS:master Sep 10, 2019
@worldofpeace worldofpeace deleted the portal-gnome-shell branch September 10, 2019 14:56
@worldofpeace
Copy link
Contributor Author

backported to 19.09 in 14faa8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants