Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: 7df30823363e
Choose a base ref
...
head repository: solvespace/solvespace
compare: bedea1ef3c8d
Choose a head ref
  • 5 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 10, 2019

  1. Remove std::move from trivially-copyable types. NFC. 

    Found by clang-tidy
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    3e566d7 View commit details
    Browse the repository at this point in the history

  2. Fix a comment. NFC. 

    Found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    c959af1 View commit details
    Browse the repository at this point in the history

  3. Fix "virtual function without virtual destructor" warning. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    78819ff View commit details
    Browse the repository at this point in the history

  4. Remove extraneous semicolon. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    b8ee0e9 View commit details
    Browse the repository at this point in the history

  5. Avoid undefined behavior from out-of-range access. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    bedea1e View commit details
    Browse the repository at this point in the history