pythonPackages.flaky: 3.5.3 -> 3.6.1 #68411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
pushed a commit
that referenced
this pull request
Sep 16, 2019
(cherry picked from commit b44fca1)
|
@disassembler should we backport this to 19.09? |
vcunat
added a commit
that referenced
this pull request
Sep 16, 2019
This reverts commit b44fca1. I'm moving this to the staging branch. It's a huge rebuild (on the order of 20k jobs), and it seems like that was not noticed, and I can't see sufficient motivation to skip ahead of e.g. the CVE fixes we have in staging-next.
vcunat
added a commit
that referenced
this pull request
Sep 16, 2019
This reverts commit a95a53a. i.e. the change is moved from the master branch to staging.
vcunat
added a commit
that referenced
this pull request
Sep 16, 2019
This reverts commit 755c9f3. I'm moving this to the staging-19.09 branch, similarly to a95a53a. It's a huge rebuild (on the order of 20k jobs), and it seems like that was not noticed, and I can't see sufficient motivation to skip ahead of other changes in staging-19.09. Here my motivation is mainly to reduce the total amount of work necessary for Hydra.
vcunat
added a commit
that referenced
this pull request
Sep 16, 2019
This reverts commit 047e326. i.e. the change is moved from the release-19.09 branch to staging-19.09.
|
As shown by GitHub, I took the liberty of moving this change to the staging branches without asking – because of causing lots of work for Hydra (apparently unintentionally). It should just delay having this change for a bit – possibly something like a week, in case of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Version update. This update fixes annoying bug box/flaky#156
Might be worth backporting to 19.09.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @