Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: Fix Windows cross compilation #68398

Merged
merged 2 commits into from Oct 26, 2019
Merged

openssl: Fix Windows cross compilation #68398

merged 2 commits into from Oct 26, 2019

Conversation

angerman
Copy link
Contributor

Replacing buildPackages.perl with perl will require perl to be built for the targetPackages, hence cross compile perl when cross compiling openssl. This hopelessly fails when cross compiling to windows.

@lheckemann
Copy link
Member

Is this only an issue on 19.03?

@angerman
Copy link
Contributor Author

@lheckemann yes. I believe so, as the perl change was not in 18.09 as far as I remember.

@lheckemann
Copy link
Member

Nothing to do with 18.09, but this should probably be targeted at master.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@domenkozar domenkozar changed the title fix openssl fix openssl for cross compilation Sep 29, 2019
@bjornfor bjornfor added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Oct 6, 2019
@angerman angerman changed the base branch from release-19.03 to master October 17, 2019 13:56
@angerman
Copy link
Contributor Author

@lheckemann against master now. Hope that's better. Will still need to be back ported when merged.

@angerman
Copy link
Contributor Author

Meta check has not much info:

nix-env failed:

@lheckemann
Copy link
Member

lheckemann commented Oct 17, 2019 •
edited by grahamc

@ofborg eval

@grahamc
Copy link
Member

grahamc commented Oct 18, 2019

The problem was that nixpkgs can no longer evaluate in 16g of ram.

@angerman
Copy link
Contributor Author

@lheckemann can we merge this, or what's holding this off?

@Ericson2314
Copy link
Member

Could we just delete c_rehash, or replace BuildPackages.perl with an executable that always returns false?

Each of those keeps build time Perl out of the run time closure, which is a good.

@Ericson2314
Copy link
Member

I tried just skipping the substituteInPlace in place, and things seemed fine. I'll just merge this for now, and try that on staging.

@Ericson2314 Ericson2314 merged commit 6a4726d into NixOS:master Oct 26, 2019
@Ericson2314 Ericson2314 changed the title fix openssl for cross compilation openssl: Fix Windows cross compilation Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@edwtjo edwtjo Awaiting requested review from edwtjo

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@rycee rycee Awaiting requested review from rycee

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@angerman @lheckemann @grahamc @Ericson2314 @bjornfor