Initial Storage Access API IDL Changes #18951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1790583
branch
2 times, most recently
from
568a191
to
219e8b8
Compare
This change adds the initial surface area for the methods and sandbox token exposed by the Storage Access API behind the storageAccessAPI runtime flag. Initially the promises created will return simple/immediate resolutions or rejections. Future changes will update the logic of each method to ensure it is functioning correctly. Additionally Web Platform Tests have been added to validate the added behaviour. As the newly added tests rely on running tests within iFrames an exposed bug in the content_shell testrunner JS has been fixed. The change ensures that iframes will not complete the testharness and that only the main frame will trigger completion. Bug: 989663 Change-Id: I2388fbc25ceb95c49435aa986191b0aca925d7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790583 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Brandon Maslen <brandm@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697926}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1790583
branch
from
219e8b8
to
d39f670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the initial surface area for the methods and sandbox token exposed by the Storage Access API behind the storageAccessAPI runtime flag. Initially the promises created will return simple/immediate resolutions or rejections. Future changes will update the logic of each method to ensure it is functioning correctly. Additionally Web Platform Tests have been added to validate the added behaviour.
As the newly added tests rely on running tests within iFrames an exposed bug in the content_shell testrunner JS has been fixed. The change ensures that iframes will not complete the testharness and that only the main frame will trigger completion.
Bug: 989663
Change-Id: I2388fbc25ceb95c49435aa986191b0aca925d7d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790583
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Brandon Maslen <brandm@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#697926}