Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fira-code: 1.207 -> 2 #68396

Merged
merged 1 commit into from Sep 10, 2019
Merged

fira-code: 1.207 -> 2 #68396

merged 1 commit into from Sep 10, 2019

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Sep 10, 2019 •
edited

Motivation for this change

Upgrade Fira Code to latest release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rycee

@ofborg ofborg bot requested a review from rycee September 10, 2019 03:23
worldofpeace
worldofpeace suggested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you install the .ttf as well?

@fabianhjr
Copy link
Member Author

@worldofpeace donzo.

@worldofpeace worldofpeace merged commit bd61f91 into NixOS:master Sep 10, 2019
@worldofpeace
Copy link
Contributor

Thanks @fabianhjr ✨

@fabianhjr fabianhjr deleted the upgrade-firacode branch September 10, 2019 03:37
@fabianhjr
Copy link
Member Author

Thanks for helping maintaining Nix/NixOS.

I use NixOS at work and at home and I am glad to contribute a little back. <3

@fabianhjr
Copy link
Member Author

Seems like adding the TTF fonts confused Emacs / Spacemacs and it grabs the ttf fonts by default.

I haven't been able to pinpoint how to make Emacs play nice with this update, however if someone is having the same issue please just disambiguate the font to be used:

EmacsWithOTF

EmacsWithTTF

@fabianhjr
Copy link
Member Author

NVM, just noticed that since my system default monospace font is Fira Code Retina and emacs didn't find the "FiraCode-Retina.otf" font it defaulted to that monospace font however the issue remains.

@fabianhjr
Copy link
Member Author

https://emacs.stackexchange.com/questions/52793/how-can-someone-set-emacs-spacemacs-to-prefer-otf-font-over-ttf-font-when-both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabianhjr @worldofpeace