Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wine #68397

Closed
wants to merge 3 commits into from
Closed

fix wine #68397

wants to merge 3 commits into from
+36 −0

Conversation

angerman
Copy link
Contributor

This fixes building wine4 on darwin and also adds wine3 back, as wine4
built with nix fails to run some programs that wine3 is capable of. As such
we add wine3 back in.

@angerman
Add cf-private on darwin.
1ac3d37
@angerman
[wine] fix build on darwin
8cae080
@angerman
[wine] Add wine3 back
3971fb6 
wine4 built with nix doesn't properly work on macOS. Further
investigation is warrented, but in the mean time let's add
wine3 back.
@ofborg ofborg bot requested review from 7c6f434c, avnik and bendlas September 10, 2019 03:36
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Sep 10, 2019
@7c6f434c
Copy link
Member

Is there a corresponding PR against master branch? Stable branches are effectively discarded at EOL, so typical workflow is to fix things in master then backport (fixing Wine build on a platform which already has some conditionals does look like a thing we normally backport); also to the upcoming release branch.

OfBorg shows 0 rebuilds on Darwin — does this mean you have kept the broken-on-Darwin flag on (probably you are using «allow unsupported platforms» in your local configuration)?

I guess we are not as careful about avoiding no-op Linux rebuilds nowadays.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@matthewbauer
Copy link
Member

Yeah "x86_64-darwin" needs to be added to meta.platforms.

@angerman angerman mentioned this pull request Oct 16, 2019
Closed
@FRidh
Copy link
Member

FRidh commented Oct 16, 2019

Closing for #71216. Backporting can be done afterwards by cherry-picking.

@FRidh FRidh closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c

@avnik avnik

@bendlas bendlas

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@angerman @7c6f434c @matthewbauer @FRidh @lheckemann