Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oracle-instantclient: 18.1.0.0.0 -> 19.3.0.0.0 (x86_64-darwin) #68381

Merged
merged 1 commit into from Sep 10, 2019
Merged

oracle-instantclient: 18.1.0.0.0 -> 19.3.0.0.0 (x86_64-darwin) #68381

merged 1 commit into from Sep 10, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 9, 2019

macos binaries are available without having to login, so we can also
remove the requireFile fetcher.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cjbj

@flokli flokli requested a review from aanderse September 9, 2019 20:46
@flokli
Copy link
Contributor Author

flokli commented Sep 9, 2019 •
edited

I haven't built this yet, as I don't have any hardware to test this on.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 labels Sep 9, 2019
@flokli @aanderse
oracle-instantclient: 18.1.0.0.0 -> 19.3.0.0.0 (x86_64-darwin)
93b55c2 
macos binaries are available without having to login, so we can also
remove the requireFile fetcher.
aanderse
aanderse approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested build on both platforms 👍

@aanderse aanderse merged commit a10ba70 into NixOS:master Sep 10, 2019
@flokli flokli deleted the instantclient-19.3-macos branch October 5, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @aanderse