New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libreoffice-fresh: 6.3.0.4 -> 6.3.2.1 #68414
Conversation
@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-kde |
@GrahamcOfBorg build libreoffice-still libreoffice-fresh libreoffice-kde |
Sigh. KDE integration apparently needs quite a bit of care… But oh well, everything is reasonable, it's just the amount of small things. Re: Still: yes, probably, it would be nice to have the same there. Re: KDE and GTK3 — our Qt5 depends on GTK3, even just Re: Still and Fresh — the idea is (or was by now?) to have a clean Fresh expression that changes when upstream changes something; and it doesn't need complicated version conditionals that will be left in place beyond the time of relevance; the Still expression gets overwritten by a copy of Fresh on minor version bumps and then typically only gets patchlevel bumps. But now the rate of upstream buildsystem changes is lower and a unified expression would not be full of kludges. |
OK, I'll fix that first then.
No there isn't. I'll clean it up.
Maybe we do this later? |
Yes, I am of course fully OK with Still and Fresh continuing to be two snapshots corresponding to different minor versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After rebase to master and bump to 6.3.2.2 it seems to build and run fine. Feel free to use my changes: https://github.com/mmilata/nixpkgs/commits/lool6322
Also tried to build the -kde variant but it crashes when I do File->Open...: https://gist.github.com/mmilata/c2cd91600b6b415349da7ba85cf6b952 |
I've tried to unify the -fresh and -still expressions, please let me know what you think: #75850 |
Motivation for this change
The main motivation was to drop gtk2/qt4 - the updated version was just a side-effect...
Support for both gtk2 and qt4 has been deprecated, so dump that.
Also add support for Qt5 and KDE.
Now, in an ideal world, the following should also happen, but I wanted to get some feedback on this first (and hopefully have this be part of .09):
still
hasn't been touched - we should at the very least dump gtk2/qt4 from there as well.-kde
variant, we should not build with gtk3 support at all (assuming that is possible)-still
and-fresh
are almost identical. They should be merged into a single function.Known issues:
SAL_USE_VCLPLUGIN=gtk3
it works, but the icons are messed up.Closes #57846
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @7c6f434c