Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sup: remove #68416

Merged
merged 1 commit into from Sep 10, 2019
Merged

sup: remove #68416

merged 1 commit into from Sep 10, 2019

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Sep 10, 2019

Motivation for this change

Abandoned by upstream, and has dependencies with quite some issues, it's about time we get rid of it.

ZHF: #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @cstrahan @lovek323 @nicknovitski

@ofborg ofborg bot added the 6.topic: ruby label Sep 10, 2019
@jtojnar jtojnar added this to To do in Picking up garbage via automation Sep 10, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Sep 10, 2019

Still needs to be dropped from pkgs/top-level/all-packages.nix:19646.

@manveru
Copy link
Contributor Author

manveru commented Sep 10, 2019

Thanks, I accidentally pushed this hunk to another branch.

worldofpeace
worldofpeace reviewed Sep 10, 2019
View reviewed changes
pkgs/development/libraries/xapian/default.nix
@@ -37,7 +37,5 @@ let
};
};
in {
# xapian-ruby needs 1.2.22 as of 2017-05-06
xapian_1_2_22 = generic "1.2.22" "0zsji22n0s7cdnbgj0kpil05a6bgm5cfv0mvx12d8ydg7z58g6r6";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need an alias also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gem was the last consumer for this library.
I considered adding 1.4.9, since that's the last version of the xapian-ruby gem, but until there's anything using it I'd say we can wait for that.

@lheckemann lheckemann added this to the 19.09 milestone Sep 10, 2019
jonringer
jonringer approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff and intent LGTM

Nothing changed
https://github.com/NixOS/nixpkgs/pull/68416
No packages were successfully build, skip nix-shell
$ git worktree prune

@jtojnar jtojnar merged commit 8ab5015 into NixOS:master Sep 10, 2019
Picking up garbage automation moved this from To do to Done Sep 10, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Sep 10, 2019

Thanks.

Cherry-picked as 1fed83d.

@manveru manveru deleted the remove-sup branch December 12, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@jonringer jonringer jonringer approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manveru @jtojnar @jonringer @worldofpeace @lheckemann