Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web-share] Use HTTPS URLs if possible #18964

Merged
merged 1 commit into from Sep 11, 2019
Merged

[web-share] Use HTTPS URLs if possible #18964

merged 1 commit into from Sep 11, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Sep 10, 2019 •
edited

Gecko currently does not support data URIs without comma (tracked by https://bugzilla.mozilla.org/show_bug.cgi?id=1579331). Since several tests here don't have to depend on data URI support, I suggest we replace them with https://example.com to reduce failures.

marcoscaceres
marcoscaceres approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that the data: URLs were nonconforming as they were missing a “,”... this was tripping up Gecko.

@saschanaz saschanaz merged commit ceea60d into master Sep 11, 2019
@saschanaz saschanaz deleted the data-comma branch September 11, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

@ewilligers ewilligers Awaiting requested review from ewilligers

@mgiuca mgiuca Awaiting requested review from mgiuca

Assignees

@mgiuca mgiuca

Labels
web-share
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschanaz @marcoscaceres @mgiuca @wpt-pr-bot