Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
base: c5f3cd151a29
Choose a base ref
...
head repository: solvespace/solvespace
compare: 7e67d3df1441
Choose a head ref
  • 9 commits
  • 29 files changed
  • 1 contributor

Commits on Sep 10, 2019

  1. Add and use List::Last(). NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    231dff6 View commit details
    Browse the repository at this point in the history

  2. For loop cleanup. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    15838dc View commit details
    Browse the repository at this point in the history

  3. Fix TTF iteration in case of an empty list.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    61c0167 View commit details
    Browse the repository at this point in the history

  4. Use IsEmpty() or .empty() to check if a container is empty. NFC. 

    Most found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    c0904e2 View commit details
    Browse the repository at this point in the history

  5. Range-for conversions and improvements. NFC. 

    Some found by clang-tidy. Some of these reduce unnecessary copies
or ref-count adjustments.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5eb556f View commit details
    Browse the repository at this point in the history

  6. Remove std::move from trivially-copyable types. NFC. 

    Found by clang-tidy
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    e31a2c4 View commit details
    Browse the repository at this point in the history

  7. Fix a comment. NFC. 

    Found by clang-tidy.
    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    9886dfc View commit details
    Browse the repository at this point in the history

  8. Fix "virtual function without virtual destructor" warning. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    e0b3172 View commit details
    Browse the repository at this point in the history

  9. Remove extraneous semicolon. NFC.

    @rpavlik @whitequark
    rpavlik authored and whitequark committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    7e67d3d View commit details
    Browse the repository at this point in the history